Skip to content

Conversation

@crasbe
Copy link
Contributor

@crasbe crasbe commented May 8, 2025

The existance of the Makefile.board.dep files in application directories was previously undocumented, but used throughout the RIOT example applications.

Contribution description

The possibility to create a board-specific Makefile.dep in the application folder was introduced in #12755, but no further documentation about it was added.

This is unfortunate, because it's used throughout RIOT already and a very useful feature, since that file (unlike the application Makefile) will be called throughout the dependency resolution phase and therefore have the latest and updated FEATURES_USED, USEMODULE, ... variables.

Testing procedure

Look at the generated Doxygen documentation.

Issues/PRs references

The feature was introduced in #12755.
The lack of documentation came up in #21442.

@crasbe crasbe requested review from aabadie and jia200x as code owners May 8, 2025 12:57
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels May 8, 2025
@github-actions github-actions bot added the Area: doc Area: Documentation label May 8, 2025
@crasbe crasbe added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label May 8, 2025
@riot-ci
Copy link

riot-ci commented May 8, 2025

Murdock results

✔️ PASSED

00db932 doc/creating-an-app: add section about Makefile.board.dep

Success Failures Total Runtime
1 0 1 01m:11s

Artifacts

The existance of the `Makefile.board.dep` files in application
directories was previously undocumented, but used throughout the
RIOT example applications.
@crasbe crasbe added this pull request to the merge queue May 16, 2025
Merged via the queue into RIOT-OS:master with commit 8e1f3b1 May 16, 2025
28 checks passed
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't able to review during the meeting, but have one nit.

Comment on lines +112 to +115
target board or architecture. This is especially
relevant for networking applications where multiple hardware implementations
exist and the appropriate one has to be chosen for the given board
or architecture.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target board or architecture. This is especially
relevant for networking applications where multiple hardware implementations
exist and the appropriate one has to be chosen for the given board
or architecture.
target board or architecture. This is especially
relevant for networking applications where multiple hardware implementations
exist and the appropriate implementation has to be chosen for the given board
or architecture.

? Not 100% sure what "one" is referring to here, so better clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants